Fixes issue where label will not display when value is False #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If text value evaluates to False, label will not display. This change resolves that issue. Tested with proximity data that returns 0 when no object is present.
caternuson
approved these changes
Feb 3, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 3, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.3.1 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#32 from kattni/fix-display-on-none > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#31 from kattni/convert-to-string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue where text value evaluates to False, label will not display.
Tested with proximity data that returns 0 when no object is present.