Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing brightness will now update the strip if auto_write is True. … #12

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Changing brightness will now update the strip if auto_write is True. … #12

merged 1 commit into from
Feb 10, 2018

Conversation

mattytrentini
Copy link
Contributor

…See Issue #10.

Tested on a Trinket M0 with a 30x LED APA102 strip.

@mattytrentini mattytrentini mentioned this pull request Feb 10, 2018
Closed
@mattytrentini
Copy link
Contributor Author

Maybe of note: While testing on the Trinket M0 I noticed that the file is now large enough to trigger a MemoryError. What's the chance that an additional 5 lines would tip it over the edge?! :)

To work around this issue on the Trinket I temporarily deleted the implementation of deinit. Worked fine (as long as deinit isn't required!) which suggests a genuine memory limit. I presume - though haven't tested - that using mpy-cross as documented here would provide another workaround.

@mattytrentini
Copy link
Contributor Author

Oh, I just noticed that the Trinket M0 has a lib directory with a dotstar.mpy file in it. Seems that Adafruit already precompiles the DotStar implementation to save memory.

tannewt
tannewt approved these changes Feb 10, 2018
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you thank you! I was meaning to do this. :-)

@tannewt
Copy link
Member

tannewt commented Feb 10, 2018

Yup! mpy-cross reduces the memory required to import the file by a lot. So, this change doesn't worry me.

@tannewt tannewt merged commit b9894d7 into adafruit:master Feb 10, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 5, 2018
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@931a805)
b740da5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 0.3.0 from 0.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#9 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS to 1.1.0 from 1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS#4 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS#3 from brentru/readthedocs-badge

Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.0.1 from 2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#6 from sommersoft/new_docs
  > Update README.rst
  > Update README.rst
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#4 from chickadee-tech/lint
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#5 from jerryneedell/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#3 from chickadee-tech/lint

Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.0.3 from 3.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#6 from dhalbert/chip_id_error
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#5 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 3.0.2 from 3.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#7 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_CCS811 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#10 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 2.2.1 from 2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#7 from brentru/fix-autodoc

Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#29 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#13 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#12 from mattytrentini/master
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#11 from mrmcwethy/examples
  > Add RTD.yaml and requirements as cookiecutter would generate them.
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#8 from chickadee-tech/master
  > Don't use requirements.txt with RTD
  > Tweak the doc badge

Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 0.8.2 from 0.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS2413 to 1.0.2 from 1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#5 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#4 from brentru/fix-autodoc
  > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#3 from brentru/readthedocs-badge

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.0.4 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#6 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#5 from brentru/fix-autodoc

Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerp to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Fingerp#6 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#6 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.0.2 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#3 from cefn/master
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#2 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.0.2 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#5 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.0.2 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA219#3 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_INA219#2 from brentru/fix-autodoc

Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.0.2 from 3.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#7 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.1.2 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#9 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 4.0.2 from 4.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#25 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303 to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303#3 from kattni/property-name-update

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#5 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#4 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#10 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#9 from mrmcwethy/addexamples

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.2.0 from 3.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#24 from caternuson/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#4 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#3 from jerryneedell/jerryn_baudrate

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.0.1 from 1.0.0:
  > Fix enable logic to invert control state.

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.3.0 from 2.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#10 from mrmcwethy/redmerst
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#9 from raidancampbell/feature/expose_functions

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 0.9.0 from 0.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#3 from kattni/joy-featherwing

Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#3 from brentru/fix-autodoc

Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#27 from brentru/fix-autodoc
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#25 from brentru/example-codes
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#26 from inventhouse/inventhouse-servo-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattytrentini @tannewt