Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ap_info #209

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Add ap_info #209

merged 3 commits into from
Jun 24, 2024

Conversation

justmobilize
Copy link
Collaborator

@justmobilize justmobilize commented Jun 12, 2024

This moves ssid, bssid and rssi to a new network class to match wifi.radio. Also added in authmode since the call was there, but not being used.

Also made firmware_version a string, since it always needs to be formated.

Once Approved, will open PRs examples in other libraries and guides.

adafruit_esp32spi/adafruit_esp32spi.py Outdated Show resolved Hide resolved
adafruit_esp32spi/adafruit_esp32spi.py Show resolved Hide resolved
adafruit_esp32spi/adafruit_esp32spi.py Outdated Show resolved Hide resolved
@justmobilize justmobilize marked this pull request as ready for review June 12, 2024 21:33
@justmobilize
Copy link
Collaborator Author

@dhalbert would love your thoughts on this

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of making a Radio-like` helper class. It will take up a little extra space when frozen or imported. I hope that won't be a problem on, say, Matrix Portal M4, but I think.

adafruit_esp32spi/adafruit_esp32spi.py Outdated Show resolved Hide resolved
adafruit_esp32spi/adafruit_esp32spi.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit e7e129a into adafruit:main Jun 24, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 25, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS248x to 1.0.1 from 1.0.0:
  > Update ds248x_simpletest.py

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.4.0 from 8.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#209 from justmobilize/add-ap-info

Updating https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#21 from justmobilize/update-wiznet-version-check

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.1.2 from 3.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#208 from RetiredWizard/monoprecision

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 4.1.1 from 4.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#195 from DJDevon3/main
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#194 from justmobilize/post-file-as-data

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_S35710, Adafruit_CircuitPython_HX711

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants