Skip to content

Convert annotation from pillow to circuitpython_typing #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2022
Merged

Convert annotation from pillow to circuitpython_typing #19

merged 1 commit into from
Aug 14, 2022

Conversation

@tekktrik
Copy link
Member

@tekktrik tekktrik commented Aug 10, 2022

Since the library is designed not to require downloading pillow, the use of circuitpython_typing.pil.Image is used for the type annotation instead.

@tekktrik tekktrik linked an issue Aug 10, 2022 that may be closed by this pull request
PIL typing annotation #18
Closed
FoamyGuy
FoamyGuy approved these changes Aug 14, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Don't have hardware to test with, but it looks to be only changed in the annotation.

Thanks for the fix to remove pillow dependency @tekktrik

@FoamyGuy FoamyGuy merged commit 55cfe59 into adafruit:main Aug 14, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 15, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@f7cc418)
89c43d4 
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#19 from tekktrik/dev/use-protocol-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.19 from 1.1.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#21 from tekktrik/dev/add-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.2.0 from 1.1.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_datetime#20 from tekktrik/fix/fix-dst-error

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.5.3 from 2.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#53 from bablokb/sparkline_opt2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PIL typing annotation

2 participants

@tekktrik @FoamyGuy