add period property to pulse and sparklepulse, fix typo #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Dec 23, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 31, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.3.0 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#44 from brian-eng/offsets Updating https://github.com/adafruit/Adafruit_CircuitPython_MPU6050 to 1.2.6 from 1.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_MPU6050#38 from FoamyGuy/samd21_ram_insufficient Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.2.2 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#33 from FoamyGuy/ev_whitebalance_getter_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.11.0 from 2.10.1: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#123 from FoamyGuy/period_property_more_animations Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiz to 1.1.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_Wiz#4 from FoamyGuy/scanning_and_mac_map Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
I think this is the feature that was being request by this comment: #65 (comment)
They called it
speedinstead of period, but I found thatspeedalready is a property on Animation super class and it is already settable and it does already affect the animation that is running. Bothspeedandperiodaffect the behavior of the animation in similar ways for some of the animations at least.