Skip to content

Fix for below 0C measurements with nominal resistance other than 100 ohms #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2020
Merged

Fix for below 0C measurements with nominal resistance other than 100 ohms #9

merged 1 commit into from
Jan 8, 2020

Conversation

@osterwood
Copy link
Contributor

This fix is based on the Adafruit C++ library for the MAX31865

https://github.com/adafruit/Adafruit_MAX31865/blob/master/Adafruit_MAX31865.cpp

@kattni kattni mentioned this pull request Mar 18, 2019
Open
@osterwood osterwood mentioned this pull request May 8, 2019
Closed
@ladyada
Copy link
Member

ladyada commented May 8, 2019

@siddacious wanna check this one out?

@ladyada ladyada requested a review from kattni May 9, 2019 21:41
@ladyada
Copy link
Member

ladyada commented May 9, 2019

also askin' @kattni

@evaherrada
Copy link
Collaborator

evaherrada commented May 25, 2019 •
edited
Loading

@ladyada, @KlaasH mentioned in #11 that these changes were already added to the C++ library a while back. I couldn't say for sure if it'd work without testing it, but it seems like it should.

kattni
kattni approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! The related issue states it was tested successfully.

@kattni kattni merged commit 17c638c into adafruit:master Jan 8, 2020
@osterwood osterwood deleted the low_temp_fix branch January 8, 2020 15:07
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 21, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@42bfc73)
4a0790d 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitSPI to 1.0.3 from 1.0.2:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitSPI#12 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitSPI#11 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.9.0 from 2.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#52 from makermelissa/matrix_scroll

Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS35HW to 1.1.3 from 1.1.2:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_LPS35HW#2 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_LPS35HW#1 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.1.1 from 3.1.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#14 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31856 to 0.8.4 from 0.8.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31856#8 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31856#7 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.1.4 from 2.1.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#9 from CapableRobot/low_temp_fix
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#15 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#14 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPRLS to 1.1.2 from 1.1.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_MPRLS#9 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MPRLS#8 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel_SPI to 0.3.2 from 0.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel_SPI#9 from caternuson/iss8

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.7.3 from 2.7.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#39 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#36 from TinyCircuits/master
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#37 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#34 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#33 from theacodes/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1322 to 1.0.1 from 1.0.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#5 from adafruit/dherrada-patch-1
  > disabling pypi deploy via actions
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#4 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.0.1 from 1.0.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#3 from adafruit/dherrada-patch-1
  > disabling pypi deploy via actions
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#2 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1331 to 1.1.2 from 1.1.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1331#7 from adafruit/dherrada-patch-1
  > disabling pypi deploy via actions
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1331#6 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1351 to 1.1.2 from 1.1.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#9 from adafruit/dherrada-patch-1
  > disabling pypi deploy via actions
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#8 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.1.1 from 1.1.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#4 from adafruit/dherrada-patch-1
  > disabling pypi deploy via actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.0.4 from 1.0.3:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#8 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#7 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.2.2 from 1.2.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#14 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#13 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.2.1 from 1.2.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#14 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 1.0.2 from 1.0.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#9 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_WS2801 to 0.9.6 from 0.9.5:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_WS2801#11 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 1.1.1 from 1.1.0:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#13 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 1.0.2 from 1.0.1:
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_NTP#6 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_NTP#7 from brentru/pypi-setup
  > disabling pypi deploy via actions
  > Merge pull request adafruit/Adafruit_CircuitPython_NTP#5 from brentru/fix-readme
  > Merge pull request adafruit/Adafruit_CircuitPython_NTP#4 from adafruit/dherrada-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kattni kattni kattni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@osterwood @ladyada @evaherrada @kattni