Skip to content

Conversation

@tannewt
Copy link
Member

@tannewt tannewt commented Mar 27, 2020

@kevinjwalters may want to look too

@tannewt tannewt requested a review from a team March 27, 2020 20:28
@kevinjwalters
Copy link

I've not executed the code but it looks ok.

I was very cautious with memory usage when writing this as I was constantly running out of memory on the CPX when developing code for https://learn.adafruit.com/cpx-midi-controller/basic-synthesizer and was forced to load less classes reducing the number of types of MIDI events I could process in the application. self._in_channel = tuple(range(16)) looks like it makes things a little bigger but having said that it's only for the "omni" mode for receiving on all channels.

@tannewt tannewt merged commit 8bf1237 into adafruit:master Mar 31, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants