Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds temperature compensation #39

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Adds temperature compensation #39

merged 3 commits into from
Sep 8, 2024

Conversation

purepani
Copy link
Contributor

@purepani purepani commented Apr 8, 2024 •
edited
Loading

Adds logic to enable temperature compensation
Since this feature pretty much requires access to the offset properties, they should be added as well.
I didn't have time today, but might add them tomorrow.

Fixes #36

@purepani
Copy link
Contributor Author

purepani commented Apr 8, 2024

Oh, it looks like i didn't lint it.
I will do that tomorrow as well since i don't have pylint installed at the moment

FoamyGuy
FoamyGuy approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I do not have the hardware to test with.

I did have a look thru the datasheet and the implementation here seems consistent with it as far as I understand it.

Thanks for adding this functionality @purepani

@FoamyGuy FoamyGuy merged commit eab0d73 into adafruit:main Sep 8, 2024
1 check passed
@purepani
Copy link
Contributor Author

purepani commented Sep 8, 2024

Thanks!
This isn't super useful at the moment actually bc I didn't add an api for setting the parameters for this iirc.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 9, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@464d350)
4179ac5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.2.0 from 2.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#39 from purepani/add_temperature_compensation

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 6.1.2 from 6.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#128 from dhalbert/usb-hid-keyboard

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#66 from timchinowsky/add_pioasm_i2c_codec

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
@brian-eng
Copy link
Contributor

@purepani Any plans on adding the offsets? Enabling temperature compensation without them returns bad values.

@purepani
Copy link
Contributor Author

purepani commented Nov 26, 2024 •
edited
Loading

I'm currently extremely busy with like 500 other things, so if you want to take a shot at a PR, go for it.
All it would require is reading and writing to the register with the tcmp values. If it's something you really need and can't do it I can maybe write something quick, but no promises

It's pretty simple to do I think, so I would recommend at least giving it a shot if you can

@brian-eng brian-eng mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a toggle to enable temperature compensation
3 participants
@purepani @brian-eng @FoamyGuy