Skip to content

Map pixels to match keys on rotation. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2021
Merged

Map pixels to match keys on rotation. #3

merged 1 commit into from
Jul 13, 2021

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Jul 13, 2021

Fixes #2.

  • Pixels now map to the key map on rotation - e.g. pixel 0 is always the upper left, etc.
  • Remove pixel brightness setting from init - now defaults to 1.

@kattni kattni requested review from a team, PaintYourDragon and jedgarpark July 13, 2021 15:17
@jedgarpark
Copy link

Tested on the MIDI Tester code, including the pixel brightness and rotation, it's all working great.

@kattni kattni merged commit 54cf70f into adafruit:main Jul 13, 2021
jedgarpark
jedgarpark reviewed Jul 13, 2021
View reviewed changes
Copy link

@jedgarpark jedgarpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 14, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@5b7e4de)
f24518a 
Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.2.0 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#11 from lesamouraipourpre/ondiskbitmap-changes
  > Moved default branch to main
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 1.1.0 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#3 from kattni/fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jedgarpark jedgarpark jedgarpark left review comments

@PaintYourDragon PaintYourDragon Awaiting requested review from PaintYourDragon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suggestions regarding and issues with initial release.

2 participants

@kattni @jedgarpark