Skip to content

Handle bad indices in the json_path #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Handle bad indices in the json_path #25

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f222b26
Handle bad indexes too
makermelissa Nov 24, 2020
1800aff
Add IndexError too
makermelissa Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adafruit_magtag/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def json_traverse(json, path):
for x in path:
try:
value = value[x]
except TypeError as error:
except (TypeError, KeyError) as error:
Copy link
Member

@tannewt tannewt Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want IndexError as well? I think that would cover lists. KeyError is for dicts I believe.

Copy link
Collaborator Author

@makermelissa makermelissa Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll add that too.

raise ValueError(
"The specified json_path was not found in the results."
) from error
Expand Down