Skip to content

MatrixPortal S3 Fixes when esp or external_spi supplied #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

MatrixPortal S3 Fixes when esp or external_spi supplied #90

merged 1 commit into from
Jun 14, 2023

Conversation

@makermelissa
Copy link
Collaborator

@makermelissa makermelissa commented Jun 14, 2023

No description provided.

@makermelissa makermelissa requested a review from a team June 14, 2023 18:38
jepler
jepler approved these changes Jun 14, 2023
View reviewed changes
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a harmless change, and possibly beneficial in case it's not feasible to change all the examples to NOT pass in these parameters when running on the matrixportals3 (or for users who would have to modify existing code)

@makermelissa
Copy link
Collaborator Author

makermelissa commented Jun 14, 2023

Thanks. My thinking on this was it will prevent breaking code on projects in the wild.

@makermelissa makermelissa merged commit e3d2b03 into adafruit:main Jun 14, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 28, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b417f43)
ad84f16 
Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.3.14 from 1.3.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#20 from caternuson/iss19

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.1.17 from 3.1.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#24 from adafruit/stemma_i2c

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 3.0.0 from 2.5.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#119 from BiffoBear/add_w6100

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.1.0 from 3.0.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#90 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#89 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jepler jepler jepler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@makermelissa @jepler