Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout value. #205

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add timeout value. #205

merged 1 commit into from
Mar 4, 2024

Conversation

LelandSindt
Copy link
Contributor

Add timeout value to avoid MMQTTException: loop timeout (0) must be bigger than socket timeout (1)) error.

@LelandSindt
Add timeout value.
c493c7b 
Add `timeout` value to avoid `MMQTTException: loop timeout (0) must be bigger than socket timeout (1))` error.
@LelandSindt
Copy link
Contributor Author

After upgrading to Circuit Python 8.x I found that mqtt_client.loop() would throw MMQTTException: loop timeout (0) must be bigger than socket timeout (1)) I had to set timeout=1 to avoid the error.

https://github.com/LelandSindt/analoguEnvoy/blob/main/circutpythonMQTT/code.py#L80

FoamyGuy
FoamyGuy approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @LelandSindt

I tested native_networking/minimqtt_adafruitio_native_networking.py and confirmed the same error as well as the fix from this PR.

My testing was on Feather ESP32S3 TFT 9.0.0.beta.2

@FoamyGuy FoamyGuy merged commit ff6f991 into adafruit:main Mar 4, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 5, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@38b61d2)
fbe4de0 
Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 3.0.4 from 3.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_FONA#32 from justmobilize/update-legacy-set-socket-examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 6.3.3 from 6.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#133 from justmobilize/fix-get-radio-ssl-context
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#132 from justmobilize/update-legacy-set-socket-examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.7 from 5.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#147 from justmobilize/fix-get-radio-ssl-context
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#146 from justmobilize/update-legacy-set-socket-examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 2.0.18 from 2.0.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#26 from justmobilize/fix-get-radio-ssl-context
  > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#25 from justmobilize/update-legacy-set-socket-examples
  > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#24 from justmobilize/fix-readme-requirements

Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 3.2.11 from 3.2.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#29 from justmobilize/fix-get-radio-ssl-context
  > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#28 from justmobilize/update-legacy-set-socket-examples
  > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#27 from justmobilize/fix-readme-requirements

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.8.2 from 5.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#118 from justmobilize/fix-get-radio-ssl-context
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#117 from justmobilize/update-legacy-set-socket-examples
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#116 from justmobilize/fix-readme-requirements

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.18 from 2.5.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#64 from justmobilize/fix-readme-requirements
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#63 from justmobilize/fix-ssl-and-set-socket

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 10.0.6 from 10.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#193 from dhalbert/deinit-characteristic-buffers

Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 2.1.2 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#18 from justmobilize/fix-get-radio-ssl-context
  > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#17 from justmobilize/update-legacy-set-socket-examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_JSON_Stream to 0.8.3 from 0.8.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_JSON_Stream#3 from bablokb/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.6.3 from 7.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#208 from justmobilize/change-free-to-close
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#205 from LelandSindt/main
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#206 from justmobilize/fix-get-radio-ssl-context

Updating https://github.com/adafruit/Adafruit_CircuitPython_OAuth2 to 1.0.17 from 1.0.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_OAuth2#12 from justmobilize/fix-get-radio-ssl-context
  > Merge pull request adafruit/Adafruit_CircuitPython_OAuth2#11 from justmobilize/update-legacy-set-socket-examples
  > Merge pull request adafruit/Adafruit_CircuitPython_OAuth2#10 from justmobilize/fix-readme-requirements

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LelandSindt @FoamyGuy