New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints #12

Merged

FoamyGuy merged 3 commits into adafruit:main from tekktrik:doc/add-typing

Jan 8, 2022

Member

tekktrik commented Jan 6, 2022

Found some time to address adding type hints to this library per Issue #11!

tekktrik added 3 commits

January 6, 2022 11:20


          Add type hints

21bce3d


          Add size parameter to docstring


          Reformatted per pre-commit

0be6dc4

tannewt requested a review from a team

January 6, 2022 17:56

FoamyGuy approved these changes

View reviewed changes

Contributor

FoamyGuy left a comment

Looks good to me thanks @tekktrik. I don't have the specific hardware for testing.

FoamyGuy merged commit ec104dc into adafruit:main

FoamyGuy mentioned this pull request

Missing Type Annotations #11

Closed

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@e796bc0)

cea974f

Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 3.0.0 from 2.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#39 from fivesixzero/cleanup-and-doc
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.3.10 from 1.3.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#21 from tekktrik/doc/add-typing
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#22 from tekktrik/doc/rtd-formatting

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#12 from tekktrik/doc/add-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.5.3 from 0.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#33 from dannystaple/patch-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet