Add helpful wrappers for errors #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
approved these changes
Jan 2, 2022
Contributor
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
Thanks, looks good. One minor piece of advice for the future.
| dist | ||
| **/*.egg-info | ||
| .vscode | ||
| .venv |
Contributor
There was a problem hiding this comment.
I always push back gently about additions like this to gitignore files.
If you commonly create ".venv" in projects where you work, it's better if you use your own global gitignore file, because it'll allow git to ignore ".venv" in any project on your system, without modifying the project gitignore file.
Here's a quick read that shows how to set it up: https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/
Contributor
Author
There was a problem hiding this comment.
Oooh - didn't know about that. Thanks.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 4, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#13 from adafruit/dhalbert-ustruct > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.9 from 2.3.8: > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#27 from KeithTheEE/crc_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#19 from CedarGroveStudios/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.11.2 from 1.11.1: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#42 from bjnhur/master > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.5.2 from 0.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#32 from dannystaple/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These wrappers make errors a bit more descriptive than "not in sequence".