Changes for the Blinka not having rtc or supervisor #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamblor21
approved these changes
Jan 14, 2021
Member
gamblor21
left a comment
gamblor21
left a comment
There was a problem hiding this comment.
Didn't test but looking it over, looks good. Only thought on RTC will it confuse blinka users if they call to set the date and it isn't set? The function does not return a date at all.
Collaborator
Author
|
Thanks. No, it isn't settable through Python, so the existing Blinka PyPortal behaves exactly like the get_local_time function without the rtc code. |
Collaborator
Author
|
Also, this is not really testable by reviewers because I'm refactoring still. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 15, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.0.4 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#29 from benetherington/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#30 from adafruit/REUSE > Added pre-commit-config file > Added pre-commit and SPDX copyright Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#9 from makermelissa/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed to work on CPython.