Update to SSD1331 driver #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Dec 28, 2017
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thanks for doing this! Just a couple minor things.
adafruit_rgb_display/ssd1331.py
Outdated
| .. code-block:: python | ||
| from machine import Pin, HSPI |
Member
There was a problem hiding this comment.
This is for micropython and should be removed. It should exist in the micropython driver.
adafruit_rgb_display/ssd1331.py
Outdated
| def __init__(self, spi, dc, cs, rst=None, width=96, height=64): | ||
| super().__init__(spi, dc, cs, rst, width, height) | ||
|
|
||
| # pylint: disable-msg=no-member |
Member
There was a problem hiding this comment.
Please add a comment why each of these lint exemptions are needed.
Contributor
There was a problem hiding this comment.
We need the __init__ here to provide default values, so it's not really useless.
Member
There was a problem hiding this comment.
Ok, thats what I was wondering.
removed micropython code block, included pylint comments
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 4, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.0.0 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#10 from mrmcwethy/lint > Update to SSD1331 driver (adafruit/Adafruit_CircuitPython_RGB_Display#11) > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#9 from deshipu/fix-small-buffer > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#8 from deshipu/fix-readinto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue with display not functioning properly. Tested successfully with SSD1331 display. Thank you to @deshipu for figuring this out!