Skip to content

Conversation

michalpokusa
Copy link
Contributor

@michalpokusa michalpokusa commented Oct 30, 2024

🪛Fixes:

  • Removed unnecessary _yield_as_sized_chunks in render_... functions
  • Added check for skipped lines in TemplateSyntaxError to avoid messages like "[-1 lines skipped]"

🏗️ Refactor:

  • Renamed _CACHE to CACHED_TEMPLATES

@michalpokusa michalpokusa changed the title Fixes and refactor Fixes for render functions chunk_size parameter and negative skipped linesin error message Oct 30, 2024
@michalpokusa michalpokusa marked this pull request as ready for review October 31, 2024 00:04
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I tested successfully with a modified simpletest on a Feather S3 TFT.

@FoamyGuy FoamyGuy merged commit be78fc3 into adafruit:main Nov 2, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 3, 2024
@michalpokusa michalpokusa deleted the fixes-and-refactor branch December 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants