Add type hints #22
Merged
Add type hints #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 25, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#24 from tekktrik/doc/add-typing > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.1.9 from 3.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#22 from tekktrik/feature/add-typing > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.14.4 from 1.14.3: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#76 from FoamyGuy/pixelmatrix_fix > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #20
It's worth mentioning that I typed the
ackgetter and setter asintbecause while you can use bool to set it, it returns an int which means you can't test for identity (is), only value. I changed the text of the associated potentialValueErrorraised to reflect this. I could definitely make a change to the code to make it trulyboolbut wanted to ask if it's worth doing.