working library & example

[ladyada]

seems to work, will take it outside to the daystar tomorrow

[ladyada]

maybe we want to add
"- pip install -r requirements.txt" to travis.yml in cookiecutter?

[ladyada]

i give up. code works, will figure out why travis is failing later

[sommersoft]

@ladyada,

maybe we want to add "- pip install -r requirements.txt" to travis.yml in cookiecutter?

We've had the discussion of adding the Blinka/PyPI stuff to cookiecutter. Just need to narrow down everything that should/can be included and how to handle the TODOs.

code works, will figure out why travis is failing later

Looks like it's failing to build rpi-ws281x:

Compiling ws281x library...

lib/ws2811.c: In function \xe2\x80\x98setup_pwm\xe2\x80\x99:\nlib/ws2811.c:395:23: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
     dma_cb->dest_ad = (uint32_t)&((pwm_t *)PWM_PERIPH_PHYS)->fif1;
                       ^
lib/ws2811.c: In function \xe2\x80\x98setup_pcm\xe2\x80\x99:
lib/ws2811.c:460:23: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
     dma_cb->dest_ad = (uint32_t)&((pcm_t *)PCM_PERIPH_PHYS)->fifo;
                       ^
cc1: all warnings being treated as errors\nmake: *** [lib-built/ws2811.o] Error 1

Looks like the same error reported in rpi-ws281x issue #12.

[ladyada]

yeah i need to figure out how to not install that on travis, but do install it on raspi only

[sommersoft]

Looks good! A few nit-noid things...

Also, I may change the VEML6070 library to match this. I wrote it without the use of @property and setter structure...

[sommersoft]

Needs to match the filename's case: `adafruit_veml6075`

[sommersoft]

Will need to uncomment, and mock micropython.

[sommersoft]

Most other libraries only have the docstring in the @property function. RTD may render integration_time twice or combine them, which could be confusing. I would just add something like, "Valid times are: 50, 100, 200, 400, or 800" to the end of the @property docstring.

Although, after reviewing a couple other doc pages, maybe we should start/change the docstrings to include the setter functions. As they stand, the API documentation does not show the available args. This may be a good in-the-weeds topic for the meeting on Monday though. Thoughts @kattni @tannewt?

[sommersoft]

Travis will flag this .. todo.

[ladyada]

@sommersoft great review, thanks - i fixed all the simple things up.

[sommersoft]

np! you even fixed one .. todo that I missed! 😄

[ladyada]

whew finally travis passes - take a look! hardware coming soon but this library can be released now :)

[ladyada]

thanks! mergin, @tannewt - lemme know if you have any changes, we wont be releasing this sensor for a week or two

[tannewt]

Looks good to me!