Add a convenience class that mimics rotaryio.IncrementalEncoder in the core #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. this wraps the core code in seesaw.py into a compatible subset of the core's rotaryio.IncrementalEncoder class.
kattni
suggested changes
May 12, 2021
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Thanks for adding this! Question below.
examples/seesaw_rotary_simpletest.py
Outdated
|
|
||
| seesaw = Seesaw(i2c_bus, addr=0x36) | ||
|
|
||
| seesaw_product = (seesaw.get_product() >> 16) & 0xFFFF |
Contributor
There was a problem hiding this comment.
The code is failing here. Where is get_product() coming from?
kattni
approved these changes
May 12, 2021
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Tested successfully on FunHouse with a STEMMA rotary encoder!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 13, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.8.1 from 1.7.2: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#64 from jepler/incrementalencoder > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#65 from jepler/use-board-i2c > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#62 from kattni/rotary-update > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#61 from jfurcean/add-basic-rotary > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#60 from rianadon/patch-1 > "Increase duplicate code check threshold "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also check the product ID as suggested by @jerryneedell from the Arduino example.
The change to the initial value of
last_positioncauses the initial position (usually 0) to be printed each time the program starts.