Fixed indexing for digits of the 7 segment display #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the implementation of writeDigitRaw to account for the fact that the colon is index 2 in the display buffer. This fact led to the documentation in the header file being incorrect with regard to all of the writeDigit functions for the Adafruit_7Segment class.
This will break existing code that uses the backpack should the users of this library update the version they're using, but the usage and effect will match the documentation and what I think is the most reasonable assumption about the related functions' behaviors.
This fixes #70, but breaks existing code using the library.