Skip to content

Conversation

lesamouraipourpre
Copy link
Contributor

Remove max_size usage from displayio.Group

Ref: #1603

Changes are need in the Learn Guide: https://learn.adafruit.com/sailor-moon-star-locket/overview

Page: https://learn.adafruit.com/sailor-moon-star-locket/circuitpython-code-walkthrough
Section: Graphics: Groups
Asset Link: https://learn.adafruit.com/pages/21957/elements/3086998/download
New version:

#  adding the two jewel circle elements to a group
jewel_splash = displayio.Group()
jewel_splash.append(jewel_outline)
jewel_splash.append(jewel)

Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, no testing performed.

It's fine & good to run black as you modify these files, but for reviewers it can be helpful if you create TWO commits, one in which you run black (the reviewer can assume that no behavior was changed in that commit) and a second one in which you make the actual change. This way, in github the reviewer can use the "Changes from [specific commit]" dropdown to focus in on the real changes.

@jepler jepler merged commit 53b6e0d into adafruit:main Jul 20, 2021
@lesamouraipourpre lesamouraipourpre deleted the cp-sailer-moon branch July 21, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants