Skip to content

Conversation

@lesamouraipourpre
Copy link
Contributor

Remove usage of max_size from displayio.Group

Ref: #1603

Learn Guide:
https://learn.adafruit.com/rgb-led-matrices-matrix-panels-with-circuitpython/overview

Changes Needed: nothing apparent

Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. No testing performed. Thank you. Thanks for the typo & other fixes, too.

Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I tested all of the updated examples on a Matrix Portal with 6.3.0

@FoamyGuy FoamyGuy merged commit 2107566 into adafruit:main Jul 25, 2021
@lesamouraipourpre lesamouraipourpre deleted the rgbmatrix branch July 28, 2021 16:14
@TheKitty
Copy link
Collaborator

Verified guide ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants