Skip to content

Conversation

lesamouraipourpre
Copy link
Contributor

Remove max_size usage with displayio.Group
Remove max_glyphs usage with Display_Text Label
Update OnDiskBitmap usage for filename string with CP7

Ref: #1603

Learn Guide:
https://learn.adafruit.com/pygamer-mp3-player-with-circuitpython

Updates needed: maybe
CircuitPython 5 is referred to on the first page and the Install JEplayer page, but nothing else jumps out.

Remove max_glyphs usage with Display_Text Label
Update OnDiskBitmap usage for filename string with CP7
Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Tested successfully on PyGamer with 7.0.0 alpha5

@FoamyGuy FoamyGuy merged commit 7845167 into adafruit:main Jul 25, 2021
@lesamouraipourpre lesamouraipourpre deleted the jeplayer-mp3 branch July 28, 2021 16:13
@TheKitty
Copy link
Collaborator

Guide verified ok, 5.3 or greater language should be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants