CLUE I Ching: Update for CP7 #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
FoamyGuy
requested changes
Jul 25, 2021
There was a problem hiding this comment.
This change looks good to me, and the specific max_size change did test successfully on a CLUE device.
If you're up to it can you make one more minor change? It's unrelated to max_size but I noticed while testing this that the text in this project is not vertically centered as it appears like it should be based on the images in the guide.
On this line:
the second value in the anchor_point should be 0.5 instead of 0.0
As the code is written now the text is shifted too far down:
With 0.5 as the second value in the anchor_point it appears in the center matching the images in the guide:
|
Verified guide ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove max_size usage with displayio.Group
Ref: #1603
Learn Guide: https://learn.adafruit.com/clue-i-ching-caster
No apparent changes needed to learn guide