Skip to content

Conversation

lesamouraipourpre
Copy link
Contributor

Remove max_size usage with displayio.Group
Update OnDiskBitmap filename string usage for CP7

Ref: #1603

Learn Guide: https://learn.adafruit.com/magtag-dishwasher-status
No apparent guide changes needed

@TheKitty for review

Update OnDiskBitmap filename string usage for CP7
Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested successfully on MagTag with 7.0.0 alpha 5

Confirmed no guide changes needed. Only place these appear are github embed

@FoamyGuy FoamyGuy merged commit 96cc0e4 into adafruit:main Jul 29, 2021
@TheKitty
Copy link
Collaborator

Guide verified

@lesamouraipourpre lesamouraipourpre deleted the dishwasher-status branch August 6, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants