snowglobe cp7 updates and background fix #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
lesamouraipourpre
approved these changes
Aug 2, 2021
TheKitty
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates for cp7. Ref: #1603
Also noticed an issue with using a color in the background causing an
AttributeErrorI suspect the type of error raised by the core code was changed and this type was not one the ones that were caught so it caused the code to crash. Fixed by adding it to the types that are caught so the code will successfully move on and set the background color.Tested with CircuitPlayground Bluefruit 7.0.0 alpha5 + TFT Gizmo
Guide: https://learn.adafruit.com/circuit-playground-tft-gizmo-snow-globe/overview-2
No changes needed in the guide