fix httpserver imports. print errors if they occur #2339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@BlitzCityDIY if you get a chance can you try this out? The httpserver library was updated after this project was published and the code needs tweaked slightly to work with the new one. I tested a minimal version, but I don't have the full project set up to try it out in the real environment. |
Collaborator
|
hihi @FoamyGuy - thanks so much! just tested and everything is working great. |
BlitzCityDIY
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: adafruit/Adafruit_CircuitPython_HTTPServer#25 changed the way imports for this library need to be coded. This PR changes to the new import syntax for the only current Learn project that uses the library.
I've also added a print statement to print errors if they are caught so that they won't be silently consumed. This can make it easier to troubleshoot if something has gone wrong.