Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PicoDVI to deps #2483

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Adding PicoDVI to deps #2483

merged 3 commits into from
Apr 24, 2023

Conversation

BlitzCityDIY
Copy link
Collaborator

Adding the PicoDVI - Adafruit Fork to the library.deps file

Adding the PicoDVI - Adafruit Fork to the library.deps file
@BlitzCityDIY
Copy link
Collaborator Author

@brentru seems like CI is running into something with the Arduino Adafruit IO library and espressif for the QT Py ESP32-S2

@brentru
Copy link
Member

brentru commented Apr 21, 2023

@BlitzCityDIY They (Espressif) just released a new BSP (2.0.8) yesterday. I'll look into this.

@brentru
Copy link
Member

brentru commented Apr 21, 2023

@brentru
Copy link
Member

brentru commented Apr 21, 2023

@BlitzCityDIY Maybe worth also including in this PR (I tested that this compiles). C++ expects a string literal (const char), so in this sketch, change the following line from: https://github.com/adafruit/Adafruit_Learning_System_Guides/blob/main/EYESPI/Arduino/Color/EYESPI_Test/EYESPI_Test.ino#L568

to

const char *label[] = { "X:", "Y:", "Z:" }; // Labels for each axis

@BlitzCityDIY
Copy link
Collaborator Author

@brentru thanks for looking into this. i was wondering if it was the new release. i can test that eyespi change and update the PR

@brentru
Copy link
Member

brentru commented Apr 21, 2023

Specifically, it's espressif/arduino-esp32#7941

Updating EYESPI test to use const char to comply with new release of espressif BSP
@brentru
Copy link
Member

brentru commented Apr 24, 2023

@BlitzCityDIY Both pull requests (adafruit/Adafruit_MQTT_Library#222 and adafruit/Adafruit_IO_Arduino#165) to the dependency libraries have been merged and the libraries have been re-released. Please give it a couple of hours to let Arduino pick up the releases, then try re-running this workflow.

If the workflow fails again, please. let me know via this issue.

@brentru
Copy link
Member

brentru commented Apr 24, 2023

Workflow is passing and @TheKitty has approved this pull request prior. Merging in.

@brentru brentru merged commit af6e673 into main Apr 24, 2023
@brentru brentru deleted the add_picodvi branch April 24, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants