Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Arduino build conditional and scheduled #2497

Merged
merged 2 commits into from
May 18, 2023

Conversation

tekktrik
Copy link
Member

@kattni - I mocked changes for what I think might be a good shift. Happy to modify, but I wanted to have something to point to.

This breaks out the Arduino build steps to their own file, which now only runs when at least one of these is true:

  • It is 3 am (daily)
  • A PR is submitted that updates a file with extensions .ino, .c, .cpp, .h, or .hpp
  • The workflow is manually triggered to run

@tekktrik tekktrik requested a review from kattni May 16, 2023 03:53
@tekktrik tekktrik marked this pull request as ready for review May 17, 2023 17:38
@tekktrik
Copy link
Member Author

Okay, this is ready! As discussed I can start a new work package for the platform+project specific builds for Arduino when submitted through PR after this one.

@tekktrik tekktrik removed the request for review from kattni May 17, 2023 17:47
@tekktrik tekktrik marked this pull request as draft May 17, 2023 17:47
@tekktrik tekktrik force-pushed the dev/arduino-cron branch 2 times, most recently from eb434ce to 4f6b313 Compare May 17, 2023 23:43
@tekktrik tekktrik marked this pull request as ready for review May 18, 2023 15:29
@tekktrik tekktrik requested a review from kattni May 18, 2023 15:30
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AMAZING. Thank you so much!

@kattni kattni merged commit f7e8bbe into adafruit:main May 18, 2023
@tekktrik tekktrik mentioned this pull request Jul 13, 2023
jepler added a commit to jepler/Adafruit_Learning_System_Guides that referenced this pull request Jun 21, 2024
Apparently since adafruit#2497, in which the extra 'checkout' line was lost,
we have not actually been building the arduino artifacts during CI.

The line may have looked like a mistake or duplicate when the CI was
revised.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants