Skip to content

Conversation

@FoamyGuy
Copy link
Collaborator

These changes are required for this update adafruit/Adafruit_CircuitPython_HTTPServer#54 in the HTTPServer library.

This is the only project currently that uses the library that I could find by searching the Learn repo and the Library Bundle Examples.

I do not have all of the exact same hardware to test the full project. I did test a version that was modified to to use a built-in display and to use hardcoded temperatures instead of reading from a sensor. With this version I was able to verify the webserver portions of the code are working as expected with these changes.

I think it should be working on the real hardware, but it may be good to try that out to confirm if possible.

@FoamyGuy
Copy link
Collaborator Author

There are 2 or 3 code sections that are in the guide on this page: https://learn.adafruit.com/pico-w-http-server-with-circuitpython/code-the-pico-w-http-server that will need updated at the time that this gets merged.

The top portion of the page is an embed of the repo file so it will update when this gets merged. But the sections underneath that include the explanations have code that is held directly in the guide rather than the repo so it'll need updated seperately.

I can make the changes in the guide when the time comes if it is helpful.

@BlitzCityDIY
Copy link
Collaborator

hihi @FoamyGuy - i had some guide feedback on this guide and tested/fixed the code this morning (PR was just merged). i'll go ahead and update the text in the guide as well.

@FoamyGuy
Copy link
Collaborator Author

Closing this one, resolved by: #2527

@FoamyGuy FoamyGuy closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants