-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concentration to AQI calculation for US and China. #12
Conversation
…d verbose info. Check start byte more strickly. Parse version and error code.
@tyeth Want to take a look at this? |
Hi @jiangyi1985 and thanks for your contribution!
I'm using this reference from the US EPA https://www.airnow.gov/sites/default/files/2020-05/aqi-technical-assistance-document-sept2018.pdf however I cannot find a reference for calculating the Chinese AQI. Most information seems very old, like before 2018, and unofficial. |
@tyeth When I wrote the code last year, I referenced this wiki page: Now that I've checked where the data of China & US are referenced, the sources seem to be legit. Here's the reference of China's data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested, but minor.
@tyeth Conflict resolved |
Thanks for the updates! I've run out of time this week and am off for a bit.
@brentru if you want to have a look, otherwise I'm back January 6th, but
there's also a very small chance I'll test it over the holiday period.
…On Thu, 19 Dec 2024 at 12:13, Ivan Jiang ***@***.***> wrote:
@tyeth <https://github.com/tyeth> Conflict resolved
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ47QQSHXKWNHWBHFFU32GKZ5LAVCNFSM6AAAAABT2U6IFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJTGYZDSMBXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiangyi1985 This PR looks good and you've made the corrections Tyeth asked. I don't see any glaring issues with it and will merge in.
Concentration to AQI calculation for US and China.
Add fail reason and verbose info.
Check start byte more strickly.
Parse version and error code.
Tested on PMSA003I-C