Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seeed_studio_esp32s3_makedown_file and seeed_studio_esp32s3 image #1500

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jasionf
Copy link

@Jasionf Jasionf commented Oct 21, 2024

No description provided.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions run failed due to missing images in the large and small folders. This page covers the process of scaling images to the appropriate sizes for those two folders. https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/preparing-the-images

@@ -0,0 +1,50 @@
---
layout: download
board_id: "seeed_xiao_esp32s3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have a board that has the id seeed_xiao_esp32s3 in the circuitpython core repo yet. So this listing will not be able to properly list its firmware download

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our ID is called seeed_xiao_esp32_s3_sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jasionf we need to figure out some details about the sense version PID and come to a consensus on how best to include the non-sense version. There are some active discussions around this in discord and over in the core repo under the PR where the sense version was added to the core. Once we have a clear path forward I will post an update here with more info.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd like to have this device added to the core first with a PR to https://github.com/adafruit/circuitpython that will require VID / PID codes which can be obtained from pid.codes. There is a page here: https://pid.codes/howto/ that details the process of submitting a PR to get codes allocated that way.

When this device does get added to the core it will be under the board_id seeed_xiao_esp32s3, and then after that is merged in we finalize this one to get it added to the downloads page.

In the meantime, I think that the sense version of the firmware can work on the non-sense device. You'll just need to be wary of some of the pins not being easily accessible to hardware.

@dhalbert
Copy link
Collaborator

dhalbert commented Nov 2, 2024

I have looked at the Seeed Xiao ESP32S3 basic board and the Sense board in more detail. The difference, as @deshipu noted, is that the Sense has the camera add on board.

There is a special very dense multi-pin connector on the base board for connecting the camera board. Because of that, the pins used for the camera are otherwise inaccessible.

Therefore, I would be inclined to make the base board be an alias of the sense board in circuitpython.org, and just have one build. Then we can avoid rounding up another USB PID. We can leave the primary name as including Sense, since it has camera capability.

@FoamyGuy does this make "sense" (oy) to you?

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Nov 2, 2024

@dhalbert yes that sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants