ESP32: Return correct deep sleep wakeup pin #10513
Merged
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ESP32,
alarm.wake_alarm.pinwas wrong, because it was return the RTC_GPIO pin number, not the regular GPIO. On ESP32 only (at present), the RTC_GPIO numbers do not line up with the regular GPIO numbers. There is no direct mapping function or table to go from RTC_GPIO to GPIO, so I just wrote a search loop to find the right pin, using the supplied mapping function the other way.Tested on Feather ESP32 V2, and tested that there was no regression on a Feather TFT ESP32-S2.
Thanks @keen101 for the bug report.