Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add German translations #1114

Merged
merged 5 commits into from
Sep 4, 2018

Conversation

turbinenreiter
Copy link

No description provided.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting this! The translations actually need to go in the msgstr part, not msgid. gettext uses the msgid to map the english in the code to the translation.

@turbinenreiter
Copy link
Author

Thanks, will fix and keep on translating tomorrow.

@tannewt
Copy link
Member

tannewt commented Aug 14, 2018 via email

@tannewt
Copy link
Member

tannewt commented Aug 17, 2018

I added string compression in #1121 so please update this PR to include it. Thanks!

@turbinenreiter
Copy link
Author

This is a lot of work and it's quite hard to find fitting translations. If anyone want's to pitch in, be my guest. Announce yourself and start from the bottom.

@tannewt
Copy link
Member

tannewt commented Aug 27, 2018

@turbinenreiter Thanks for you hard work on this! How about taking a break, fixing the build and getting what you have so far checked in? Thanks!

@turbinenreiter
Copy link
Author

Travis build failure:

$ (cd tests && for exp in *.exp; do testbase=$(basename $exp .exp); echo -e "\nFAILURE $testbase"; diff -u $testbase.exp $testbase.out; done)
FAILURE *
diff: *.exp: No such file or directory
diff: *.out: No such file or directory

Not sure what that means.

@tannewt
Copy link
Member

tannewt commented Sep 4, 2018

Where are you seeing this? I see this when I click through:

../../locale/de_DE.po:196: 'msgid' and 'msgstr' entries do not both end with '\n'
../../locale/de_DE.po:213: 'msgid' and 'msgstr' entries do not both end with '\n'
../../locale/de_DE.po:223: 'msgid' and 'msgstr' entries do not both end with '\n'

@turbinenreiter
Copy link
Author

Somewhere in the Travis build - where are you seeing the useful messages?

Fixed the three lines you mentioned, let's see what Travis thinks of it.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passed and looks good!

@tannewt
Copy link
Member

tannewt commented Sep 4, 2018

I got the error message from here: https://travis-ci.org/adafruit/circuitpython/jobs/420733737#L626

@tannewt tannewt merged commit 7654106 into adafruit:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants