Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ES locale strings #1718

Merged
merged 3 commits into from
Mar 29, 2019
Merged

New ES locale strings #1718

merged 3 commits into from
Mar 29, 2019

Conversation

yeyeto2788
Copy link

No description provided.

@yeyeto2788
Copy link
Author

@C47D, @sabas1080 when you guys get a chance, can you please check the PR? I might add more things tomorrow (28/Mar/2019).

Regards.

@sabas1080 sabas1080 self-requested a review March 27, 2019 19:27
@C47D C47D self-requested a review March 27, 2019 20:29
@C47D
Copy link
Collaborator

C47D commented Mar 27, 2019

Hi @yeyeto2788 you beat me to it, i was planning to take a look into the translation later today. 👍

@yeyeto2788
Copy link
Author

Hello guys!

@C47D, @sabas1080, @tannewt

Found some errors on build:
image

image

They seems to be regarding other languages and flash size issue, can anyone help me out to get the build working?

Another quick question? Where is the build for the ESP8266 or the ESP32? I don't see it on the CI job

@deshipu
Copy link

deshipu commented Mar 28, 2019

Another quick question? Where is the build for the ESP8266 or the ESP32? I don't see it on the CI job

There was never a build for the ESP32, and ESP8266 is officially no longer supported in 4.0 and has been removed.

@dhalbert
Copy link
Collaborator

@yeyeto2788 Hi - your build problems are probably due to changes from upstream that haven't been incorporated in your PR (we fixed the "too big" errors).

Instead of merging from master in your fork, try keeping your master in sync with adafruit/circuitpython. Do a local branch for your changes. This will be easier. We have a Learn Guide explaining our GitHub workflow here: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github.

@yeyeto2788
Copy link
Author

yeyeto2788 commented Mar 29, 2019

@deshipu thanks for the info, anyway to get lastes available realease for ESP8266 and ESP32?

@dhalbert I'll read it and fix it. Thanks.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience dealing with git!

@yeyeto2788
Copy link
Author

Wujuuuu! Finally working. Sorry for the mess.

@dhalbert dhalbert merged commit 7e99b2d into adafruit:master Mar 29, 2019
@dhalbert
Copy link
Collaborator

Re releases:
The latest working ESP8266 release is 3.1.2: https://github.com/adafruit/circuitpython/releases/tag/3.1.2
There has never been a CircuitPython ESP32 build. There is a MicroPython ESP32 build.

@yeyeto2788
Copy link
Author

My bad, I thought there was one for the ESP32 but also with the ESP8266 one is good for me. Sad that is not supported now from 4.0 on.

Keep it up and if there is anythig I can help with, just let me know.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants