Skip to content

Conversation

@tannewt
Copy link
Member

@tannewt tannewt commented Aug 28, 2019

Here is a normal test build: https://github.com/tannewt/circuitpython/runs/205207009

It failed on S3 upload because my repo doesn't have the secret set.

The release uploads are working but got rate limited: https://github.com/tannewt/circuitpython/runs/205075094 Theoretically we can squeeze under the 1,000 request limit of the repo token with a single release but we may need to use a separate token if not.

@tannewt tannewt added this to the 5.0.0 milestone Aug 28, 2019
@tannewt tannewt requested review from dhalbert and sommersoft August 28, 2019 03:10
sommersoft
sommersoft previously approved these changes Aug 28, 2019
Copy link

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an excellent jump-off to me!

Its been hard to concentrate on a review, without my mind wandering off into "what if..." scenarios. Thanks for this. 👏

@sommersoft
Copy link

sommersoft commented Aug 28, 2019

I have a couple thoughts, but I don't think they warrant holding this up:

  • Break the workflow and actions into separate files. Scrolling down through 72 builds is cumbersome. And while all of the builds are technically ARM, grouping them by chipset (like the ports directory does), might be more intuitive. It wouldn't necessarily require duplicated code all over the place, if I'm reading the docs correctly. The meat of the build can be placed into a .github/actions/build_board.yml, and called from the workflows. P.S. I love the return of the build output; I've missed the flash/RAM stats

  • For the release uploads, would adding rate-limit handling to post in adabot (like get has) work? I can't find any info on idle timeouts (but haven't looked too hard). At the current rate, pretty sure we'll be above 1000 earlier than most of us think. (🤞)

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I have no comments about the details.

In terms of rate limiting, can we avoid triggering it by doing our own rate limiting by delaying between requests?

@tannewt
Copy link
Member Author

tannewt commented Aug 29, 2019

I have a couple thoughts, but I don't think they warrant holding this up:

* Break the workflow and actions into separate files. Scrolling down through 72 builds is cumbersome. And while all of the builds are technically ARM, grouping them by chipset (like the ports directory does), might be more intuitive. It wouldn't necessarily require duplicated code all over the place, if I'm reading the docs correctly. The meat of the build can be placed into a `.github/actions/build_board.yml`, and called from the workflows. _P.S. I love the return of the build output; I've missed the flash/RAM stats_

I don't think we can get away from the 72 build thing. Making it workflow will just lead to 72 workflows. I'm not sure about the cross-referencing. Would be good for you to try. ;-)

* For the release uploads, would adding rate-limit handling to `post` in adabot (like `get` has) work? I can't find any info on idle timeouts (but haven't looked too hard). At the current rate, pretty sure we'll be above 1000 earlier than most of us think. (🤞)

Ya, we could but then the build will take longer. I'd rather just give it a normal api key with 4,000 limit per hour.

@tannewt tannewt merged commit 193df55 into adafruit:master Aug 29, 2019
@ladyada
Copy link
Member

ladyada commented Aug 29, 2019

yayyyy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants