-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Swap the CI to GitHub Actions from Travis #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sommersoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an excellent jump-off to me!
Its been hard to concentrate on a review, without my mind wandering off into "what if..." scenarios. Thanks for this. 👏
|
I have a couple thoughts, but I don't think they warrant holding this up:
|
dhalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but I have no comments about the details.
In terms of rate limiting, can we avoid triggering it by doing our own rate limiting by delaying between requests?
I don't think we can get away from the 72 build thing. Making it workflow will just lead to 72 workflows. I'm not sure about the cross-referencing. Would be good for you to try. ;-)
Ya, we could but then the build will take longer. I'd rather just give it a normal api key with 4,000 limit per hour. |
|
yayyyy |
Here is a normal test build: https://github.com/tannewt/circuitpython/runs/205207009
It failed on S3 upload because my repo doesn't have the secret set.
The release uploads are working but got rate limited: https://github.com/tannewt/circuitpython/runs/205075094 Theoretically we can squeeze under the 1,000 request limit of the repo token with a single release but we may need to use a separate token if not.