Skip to content

Conversation

@arturo182
Copy link
Collaborator

Tested with a board I'm working on :)

@arturo182 arturo182 added this to the 5.0.0 milestone Sep 2, 2019
@arturo182 arturo182 requested a review from tannewt September 2, 2019 21:24
@arturo182
Copy link
Collaborator Author

The build failed but that doesn't seem to be my code's fault 😅

msgfmt: error while opening "build/genhdr/en_US.mo" for writing: No such file or directory
../../py/py.mk:320: recipe for target 'build/genhdr/en_US.mo' failed
make: *** [build/genhdr/en_US.mo] Error 1

@dhalbert
Copy link
Collaborator

dhalbert commented Sep 3, 2019

@arturo182 I simulated the build on my own machine and didn't see this issue. I re-ran the build a couple of times and now it's failing even earlier, not being able to find a commit. I'd guess there are some issues on the GitHub Actions side; we can try again in the morning.

@arturo182
Copy link
Collaborator Author

No worries, this is not a high prio commit, just wanted to have it here so I don't lose track of it :)

The GitHub Actions build for this PR is failing for reasons that make no sense. Make a tiny commit change to see if it will refresh things and work again.
@dhalbert
Copy link
Collaborator

dhalbert commented Sep 3, 2019

I tried re-rerunning this morning and the check-run again failed trying to find a commit. I made a trivial typo fix to force a new commit and new check run, and it worked.

@dhalbert
Copy link
Collaborator

dhalbert commented Sep 3, 2019

Thank you for the addition!

@dhalbert dhalbert merged commit de7a603 into adafruit:master Sep 3, 2019
@arturo182 arturo182 deleted the GD25Q32C branch September 3, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants