Improve USB eject by resetting on replug #2406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Dec 18, 2019
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
This seems good to me, but @hathach will have the last word.
I would note that Windows doesn't seem to have any easy way to actually eject. "Eject" doesn't dismount, but it does do all pending writes and mark the drive as "clean".
hathach
reviewed
Dec 18, 2019
hathach
approved these changes
Dec 18, 2019
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
This is great changes, msc mount/umount together with enumeration make perfect sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the issue where leaving a CIRCUITPY drive plugged in leads to a crash.