Update CI #4334
Closed
Update CI #4334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Mar 5, 2021
Print Failure Info is for printing differences detected by 'Test all'. When some other step fails, then "*.exp" doesn't match any files at all, and _this_ step fails too. Following https://stackoverflow.com/questions/4839214/does-ash-have-an-equivalent-to-bashs-nullglob-option detect when "*.exp" doesn't match anything and avoid an error. This is hard to test, so testing performed: Looked at 7 lines of shell script and was unable to see any problems. This is an alternative to adafruit#4334, which would remove the step entirely. It is undesirable to do that, as we wouldn't be able to see the information about the failures that occurred anymore.
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Mar 5, 2021
Print Failure Info is for printing differences detected by 'Test all'. When some other step fails, then "*.exp" doesn't match any files at all, and _this_ step fails too. Following https://stackoverflow.com/questions/4839214/does-ash-have-an-equivalent-to-bashs-nullglob-option detect when "*.exp" doesn't match anything and avoid an error. This is hard to test, so testing performed: Looked at 7 lines of shell script and was unable to see any problems. This is an alternative to adafruit#4334, which would remove the step entirely. It is undesirable to do that, as we wouldn't be able to see the information about the failures that occurred anymore.
Collaborator
|
Closing in favor of #4340. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Print failure infofrom CI as in the case of a failure the ui defaults to showing it, hiding whatever fails above.