Add board-specific pico-sdk settings; set xosc multiplier for Adafruit boards #5085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I have a MacroPad that was getting stuck into a "doing nothing" type state after being unplugged / re-plugged after flashing CircuitPython. I tested a build from this branch on that device and confirmed that this build allows it to be unplugged / re-plugged and continues to work as normal. |
dhalbert
pushed a commit
to dhalbert/circuitpython
that referenced
this pull request
Aug 4, 2021
…k-settings Add board-specific pico-sdk settings; set xosc multipler for Adafruit boards
dhalbert
changed the title
Collaborator
Author
|
See original fix here: adafruit/pico-sdk#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The longer xosc delay startup was inadvertently lost when we switched back to the
raspberrypi/pico-sdksubmodule. So7.0.0-alpha.5did not have the XOSC fix for Adafruit boards. This is a regression which can cause a few samples of boards not to work.Add the fix back, by
#includeing a board-specific file in thepico-sdkglobal config fileports/raspberrypi/sdk_config/pico/config_autogen.h.I would do an alpha.6 very soon to get this out.