Skip to content

Conversation

@scath999
Copy link

Make File Changes

  • Created new compile time flag CIRCUITPY_INTERNAL_PULLUPS: defaults to 0
  • Created new #define for HAS_INTERNAL_PULLUPS: set to true if CIRCUITPY_INTERNAL_PULLUPS is 1, false otherwise
  • Added CIRCUITPY_INTERNAL_PULLUPS = 1 to ports/nrf/mpconfigport.mk to take advantage of extended functionality.

Code level changes

  • Added boolean MP_QSTR_internal_pullup as optional argument for i2c related construction calls: defauls to false.
  • Modified function signatures for common_hal_busio_i2c_construct, shared_module_bitbangio_i2c_construct, busio_i2c_make_new, bitbangio_i2c_make_new to include this new parameter.

Documentation Changes

  • Amended documentation within appropriate files to expose new optional parameter: :param bool internal_pullups: Set pulls on each pin to up if board supports internal pullups - defaults to false

…fic code for nrf52833 to take advantage of this
@scath999 scath999 closed this Dec 14, 2021
@scath999 scath999 deleted the nrf_internal_pullup_feature branch December 15, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant