Skip to content

Conversation

@dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Sep 27, 2022

This isn't necessarily less code than before but it's easier to understand.

Tested on an ESP32-S2 TFT. Further testing welcomed if you feel so inclined.

Note that #6892 is not fixable on boards with a USB-serial converter chip, unless the status pins on the chip are connected to something, which is typically not the case.

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The logic changes make sense. I didn't test.

@dhalbert dhalbert merged commit d3449bd into adafruit:main Sep 28, 2022
@dhalbert dhalbert deleted the simpler-status-bar-code branch September 28, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CircuitPython 8.X title-set ansi code sometimes ends up in stdin

2 participants