Revert "Correctly raise OS error in socketpool_socket_recv_into()" #7779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7e6e824. Fixes adafruit#7770 The change in adafruit#7623 needs to be revered; the raise-site added in adafruit#7632 is the correct one and the one in socketpool needs to be reverted. This is not affecting 8.0.x because adafruit#7623 was not back-ported to there before we realized it was not a full fix. Both adafruit#7770 and adafruit#7606 should be re-tested. I didn't test.
dhalbert
approved these changes
Mar 22, 2023
|
Successfully tested #7770 with local build of latest main branch bits and this change. Seems to work fine, Thanks. |
|
Successfully tested #7606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7e6e824.
Fixes #7770
The change in #7623 needs to be revered; the raise-site added in #7632 is the correct one and the one in socketpool needs to be reverted.
This is not affecting 8.0.x because #7623 was not back-ported to there before we realized it was not a full fix.
Both #7770 and #7606 should be re-tested. I didn't test.