Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh_Latn_pinyin.py #7913

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Update zh_Latn_pinyin.py #7913

merged 3 commits into from
Apr 27, 2023

Conversation

ChenxiXiao
Copy link

@ChenxiXiao ChenxiXiao commented Apr 26, 2023

added missing string translation for Chinese PinYin #1098

image

@ChenxiXiao
Copy link
Author

Question: Is Chinese character not supported? Only US-ASCII encoding strings?

@tannewt
Copy link
Member

tannewt commented Apr 26, 2023

The strings are UTF-8 encoded. We could have a chinese character translation if you like. We would disable the terminal on displays because of the many characters needed in the font.

@ChenxiXiao
Copy link
Author

@tannewt could you approve my pr?

@tannewt
Copy link
Member

tannewt commented Apr 26, 2023

Did you make it directly? Usually we get translation updates through weblate.

@ChenxiXiao
Copy link
Author

yeah I made the changes directly

@tannewt
Copy link
Member

tannewt commented Apr 26, 2023

Ok, I'll merge when the CI is done. Weblate is preferred I think because it keeps a newer copy of translations potentially.

@dhalbert dhalbert requested a review from tannewt April 26, 2023 19:20
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit f1ebd90 into adafruit:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants