Make version-checking compatible with updated Packaging library. #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the
packaging
library removed theLegacyVersion
class [1]. This has resulted in Neurite'ssetup.py
script throwing the following error at installation time:AttributeError: module 'packaging.version' has no attribute 'LegacyVersion'
Proposed fix:
Instead of checking if the (parsed)
version
string is aLegacyVersion
object, use thepackaging.version.parse(version)
function to parse theversion
string and catch anyInvalidVersion
exception. If an exception is raised, then its not a validversion
string according to the PEP 440 specification.[1] pypa/packaging#530