forked from OSSystems/meta-browser
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chromium: [PATCH] Revert "Set Rust symbol visibility to hidden when ..."
This reverts chromium commit ee3900fd57b3c580aefff15c64052904d81b7760. * Change-Id: https://crrev.com/c/5966273 Fixes the following compilation error: ``` | FAILED: obj/third_party/rust/ryu/v1/lib/libryu_lib.rlib [...] | error: unknown unstable option: `default-visibility` ``` This patch will be dropped once Rust >= 1.83 is available, which includes: * rust-lang/rust#130005 [0] * rust-lang/rust#131519 [1] Note that currently meta-lts-mixins [2] provides the following versions: * kirkstone: `1.80.1` * scarthgap: `1.81.0` [0] rust-lang/rust#130005 [1] rust-lang/rust#131519 [2] https://git.yoctoproject.org/meta-lts-mixins Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
- Loading branch information
1 parent
79350e7
commit 7204798
Showing
2 changed files
with
74 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
...es-browser/chromium/files/0013-Revert-Set-Rust-symbol-visibility-to-hidden-when-C-s.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
From 6302ea4936e24232af4d50257b94a079471063cf Mon Sep 17 00:00:00 2001 | ||
From: Ariel D'Alessandro <ariel.dalessandro@collabora.com> | ||
Date: Thu, 14 Nov 2024 22:23:28 -0300 | ||
Subject: [PATCH] Revert "Set Rust symbol visibility to hidden when C++ symbols | ||
are" | ||
|
||
This reverts chromium commit ee3900fd57b3c580aefff15c64052904d81b7760. | ||
* Change-Id: https://crrev.com/c/5966273 | ||
|
||
Fixes the following compilation error: | ||
|
||
``` | ||
| FAILED: obj/third_party/rust/ryu/v1/lib/libryu_lib.rlib | ||
[...] | ||
| error: unknown unstable option: `default-visibility` | ||
``` | ||
|
||
This patch will be dropped once Rust >= 1.83 is available, which | ||
includes: | ||
* rust-lang/rust#130005 [0] | ||
* rust-lang/rust#131519 [1] | ||
|
||
Note that currently meta-lts-mixins [2] provides the following versions: | ||
* kirkstone: `1.80.1` | ||
* scarthgap: `1.81.0` | ||
|
||
[0] https://github.com/rust-lang/rust/pull/130005 | ||
[1] https://github.com/rust-lang/rust/pull/131519 | ||
[2] https://git.yoctoproject.org/meta-lts-mixins | ||
|
||
Upstream-Status: Inappropriate [specific to older versions of rust] | ||
Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com> | ||
--- | ||
build/config/gcc/BUILD.gn | 1 - | ||
build/sanitizers/asan_suppressions.cc | 13 +++++++++++++ | ||
2 files changed, 13 insertions(+), 1 deletion(-) | ||
|
||
diff --git a/build/config/gcc/BUILD.gn b/build/config/gcc/BUILD.gn | ||
index a659210b196aa..147ebfc53426c 100644 | ||
--- a/build/config/gcc/BUILD.gn | ||
+++ b/build/config/gcc/BUILD.gn | ||
@@ -32,7 +32,6 @@ declare_args() { | ||
# See http://gcc.gnu.org/wiki/Visibility | ||
config("symbol_visibility_hidden") { | ||
cflags = [ "-fvisibility=hidden" ] | ||
- rustflags = [ "-Zdefault-visibility=hidden" ] | ||
|
||
# Visibility attribute is not supported on AIX. | ||
if (current_os != "aix") { | ||
diff --git a/build/sanitizers/asan_suppressions.cc b/build/sanitizers/asan_suppressions.cc | ||
index bfbd4b792a919..f0557be762c40 100644 | ||
--- a/build/sanitizers/asan_suppressions.cc | ||
+++ b/build/sanitizers/asan_suppressions.cc | ||
@@ -15,6 +15,19 @@ | ||
// // http://crbug.com/178677 | ||
// "interceptor_via_lib:libsqlite3.so\n" | ||
char kASanDefaultSuppressions[] = | ||
+ // https://crbug.com/1471542 false positive odr violations from Rust code. | ||
+ "odr_violation:^core::\n" | ||
+ "odr_violation:^object::\n" | ||
+ "odr_violation:^std::io::\n" | ||
+ "odr_violation:^serde::\n" | ||
+ "odr_violation:^serde_json_lenient::\n" | ||
+ "odr_violation:^std::panicking::\n" | ||
+ "odr_violation:^std::thread::Builder::\n" | ||
+ "odr_violation:^read_fonts::tables::\n" | ||
+ "odr_violation:^std_detect::detect::cache::\n" | ||
+ "odr_violation:^alloc::sync::\n" | ||
+ "odr_violation:^log::\n" | ||
+ | ||
// End of suppressions. | ||
// PLEASE READ ABOVE BEFORE ADDING NEW SUPPRESSIONS. | ||
""; // Please keep this semicolon. |