Added forgot-to-render detection #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome refactoring and options work to do. And Thunderbird.
…+Opera. Added some test cases. Refactored Firefox to use new background request style.
…This should take care of the rampant false-positive forgot-to-render prompts.
…eedback suggested that it's nice than the HTML prompt we're using for Chrome.) Some refactoring should still be done to reduce code duplication between Firefox and Thunderbird (i.e., the openDialog call).
…rbird if option is turned off.
…oduced while working on Safari. Fix some jshint warnings.
…update when rendering complete. This avoids the window where the user could render, quickly attempt to send, and be told they hadn't yet rendered.
…aving marked.js as a parameter for now, though. Still thinking about the best way to do detection.)
…ed the need for a document parameter to markdownRender.
…-to-render MD detection. Still need to get rid of now-duplicate html-to-text code used when rendering.
…eck is now done at send time rather than periodically. Made new HTML-to-text code also take a range. Test cases need updating.
… it to default to false (for now).
adam-p
added a commit
that referenced
this pull request
Sep 30, 2013
Added forgot-to-render detection
jfx2006
added a commit
to jfx2006/markdown-here
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to send an email Thunderbird, Postbox, or Gmail (all browsers), Markdown Here will detect whether there is raw, unrendered Markdown in the email and prompt the user to either go back and render or continue to send.
Closes issue #90.