Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat "application/problem+json" as non binary by default #503

Merged

Conversation

idosavion
Copy link
Contributor

@idosavion idosavion commented Jun 25, 2024

Tests are green locally and seems like this area has test coverage, but please let me know if you'd like me to change parameters/add more test cases

@adamchainz
Copy link
Owner

Where does this come from? I need an issue before a random patch.

@idosavion
Copy link
Contributor Author

idosavion commented Jun 25, 2024

  1. Thanks for the quick response!
  2. I'll open up an issue and connect it to the PR if you want me to (I thought this would improve the code base, there wasn't a bug in the code)
  3. This hasn't caused an issue on our end, but we thought other users of the repository would benefit from it, as the mime-type used in connexion is application/problem+json, which is often used to convey errors in a HTTP response

@adamchainz
Copy link
Owner

If it hasn't caused any issues, I'd rather do nothing. Especially since it sounds like you haven't tested the change in production..?

@idosavion
Copy link
Contributor Author

idosavion commented Jun 25, 2024

We effectively tested the change in production as we're propagating a list of all the defaults and application/problem+json to non_binary_content_type_prefixes when creating our lambda handler using make_lambda_handler

Ido Savion and others added 3 commits October 7, 2024 21:45
@adamchainz adamchainz force-pushed the isavion/treat-json-problem-as-non-binary branch from 8b45bea to 63d1531 Compare October 7, 2024 20:48
@adamchainz adamchainz enabled auto-merge (squash) October 7, 2024 20:49
@adamchainz adamchainz merged commit 88fecf8 into adamchainz:main Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants