-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for notebook style code #240
Comments
@adamchainz I don't want to be too pushy, but as you are the maintainer would I be able to ask if you have any thoughts on this? |
Yes, let's add the new parser, but leave the "check" function for now. I previously discussed a "check"/"dry run" feature in #197 and concluded that it's not worth it when Please can you update your PR to include docs, tests, and a changelog note? |
Cool will do.
Can do.
|
MyST is designed with notebook support in mind (amongst other things). As a result, you have to use black's I don't think these need to be added as dependencies because the module not found error is clear enough for the user (but I'm happy if you have a way you want to handle optional dependencies). Ways I could see to handle this:
For the tests, these extra modules do need to be installed for the MyST-related tests to pass. What is your preferred way to do this? Options I see:
|
Hi @adamchainz, I'm back looking at stuff related to this again and wondered if you had any thoughts? I'll then add them to #239 and mark that as ready for review. Thanks again |
Description
Firstly thanks for such an awesome tool.
In my repository, I wrote jupyter notebooks, which I then save to markdown files using jupytext. I would like to run black over these files. blacken-docs is almost perfect for this, but it just needs support for this style of code block.
I've put an implementation here #239, I needed to do two things:
As part of #239, I also added a 'check' functionality.
It would be great to get feedback on:
Assuming that the answer to either or both of the above is yes, I will make a new PR for them (also separating them so that the two changes don't end up being coupled).
This is sort of related to #127 I think
Thanks again for your efforts!
The text was updated successfully, but these errors were encountered: